Mocks added for statutils #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/M
mkumatag
requested changes
Feb 16, 2022
pkg/driver/sanity_test.go
Outdated
| stagingPath := filepath.Join(dir, "staging") | ||
| endpoint := "unix://" + filepath.Join(dir, "csi.sock") | ||
|
|
||
| config := &sanity.Config{ | ||
| TargetPath: targetPath, |
There was a problem hiding this comment.
I'm wondering whether we can just pass this targetPath into the MockStatSanity struct and use it instead of making this global?
Madhan-SWE
force-pushed
the
sanity_fixes
branch
from
e2e87f3
to
bb1baae
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhan-SWE, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Mocks added for StatUtils in sanity tests.
Which issue(s) this PR fixes:
Fixes #118