Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale tests added #127

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Scale tests added #127

merged 1 commit into from
Mar 1, 2022

Conversation

Madhan-SWE
Copy link

What type of PR is this?
/kind feature

What this PR does / why we need it:
Added necessary files for scale testing with tube-burner

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 21, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Madhan-SWE. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 21, 2022
@Madhan-SWE
Copy link
Author

/test

@k8s-ci-robot
Copy link
Contributor

@Madhan-SWE: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@piyushgupta1551
Copy link

lgtm
@mkumatag pls trigger a /test

@mkumatag
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 21, 2022
mkumatag
mkumatag requested changes Feb 21, 2022
View reviewed changes
tests/scale/kube-burner/templates/pod.yaml Outdated
spec:
containers:
- name: app-{{.Iteration}}-{{.Replica}}
image: centos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if we can use k8s.gcr.io/pause:3.6 image because

  • centos image is already dead
  • to have faster image pull because of lesser in size
  • no need to have infinite while loop

@mkumatag
Copy link
Member

/retest

@Madhan-SWE
Copy link
Author

Updated with pause container image.
Yet to be tested on kubernetes cluster.

@mkumatag
Copy link
Member

/retest

@mkumatag
Copy link
Member

mkumatag commented Mar 1, 2022

Updated with pause container image.
Yet to be tested on kubernetes cluster.

were you able to test the scale with pause container? wondering if we can merge this PR :)

@Madhan-SWE
Copy link
Author

Madhan-SWE commented Mar 1, 2022 •
edited

@mkumatag Testing with pause container is successful. PR can be merged.

mkumatag
mkumatag approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhan-SWE, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit ddb4138 into kubernetes-sigs:main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Madhan-SWE @k8s-ci-robot @piyushgupta1551 @mkumatag @rcmadhankumar