Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate NodeUpdate controller with csi-driver #150

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Integrate NodeUpdate controller with csi-driver #150

merged 1 commit into from
Mar 18, 2022

Conversation

Prajyot-Parab
Copy link
Contributor

Signed-off-by: Prajyot-Parab prajyot.parab2@ibm.com

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • Phase 1 : Integrate node-update-controller with csi-driver

Which issue(s) this PR fixes:

Fixes #149

Special notes for your reviewer:

Release note:

Integrate NodeUpdate controller with csi-driver

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 16, 2022
Madhan-SWE
Madhan-SWE reviewed Mar 17, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Madhan-SWE
Madhan-SWE suggested changes Mar 17, 2022
View reviewed changes
Copy link

@Madhan-SWE Madhan-SWE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@Madhan-SWE
Copy link

Madhan-SWE commented Mar 17, 2022 •
edited

Having a separate Makefile and Dockerfile placed in ad hoc-controller folder can be a good solution.
@mkumatag what do you think?
(we can treat it as a separate component like the centos base image)

mkumatag
mkumatag requested changes Mar 17, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed offline, lets build the binary and include into the same docker image instead of different image.

mkumatag
mkumatag requested changes Mar 17, 2022
View reviewed changes
adhoc-controllers/main.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 17, 2022
mkumatag
mkumatag requested changes Mar 18, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits to avoid multiple layers in the docker image.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@Prajyot-Parab
Integrate NodeUpdate controller with csi-driver
71569d4 
Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2022
mkumatag
mkumatag approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit d4f1dbb into kubernetes-sigs:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@Madhan-SWE Madhan-SWE Awaiting requested review from Madhan-SWE

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate node-update-controller with csi-driver
4 participants
@Prajyot-Parab @Madhan-SWE @k8s-ci-robot @mkumatag