Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node update controller added to the deployments #158

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Node update controller added to the deployments #158

merged 2 commits into from
Mar 21, 2022

Conversation

Madhan-SWE
Copy link

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adding node update controller to the deployments.

Which issue(s) this PR fixes:

Fixes #157

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 18, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2022
mkumatag
mkumatag requested changes Mar 18, 2022
View reviewed changes
deploy/kubernetes/base/controller.yaml
Comment on lines +69 to +74
- name: metrics
containerPort: 8081
protocol: TCP
- name: healthz
containerPort: 8082
protocol: TCP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prajyot-Parab are we exposing metrics and healthz from the controller?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, then @Madhan-SWE can we add livenessProbe probe then.?

deploy/kubernetes/base/controller.yaml
@@ -62,6 +62,23 @@ spec:
timeoutSeconds: 3
periodSeconds: 10
failureThreshold: 5
- name: node-update-controller
image: quay.io/powercloud/ibm-powervs-block-csi-driver:v0.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow we need to get rid of this image quay.io/powercloud/ibm-powervs-block-csi-driver:v0.0.1 of course not via this PR but we need to remove from everywhere.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can give gcr path: gcr.io/k8s-staging-cloud-provider-ibm/ibm-powervs-block-csi-driver:v1.0.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about gcr.io/k8s-staging-cloud-provider-ibm/ibm-powervs-block-csi-driver:dev something more meaningful and assume this will get overridden with an actual image later.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be changing all the image Paths to gcr.io/k8s-staging-cloud-provider-ibm/ibm-powervs-block-csi-driver:dev in a new PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or even it can be gcr.io/k8s-staging-cloud-provider-ibm/ibm-powervs-block-csi-driver:main

deploy/kubernetes/overlays/dev/main_image.yaml
@@ -27,3 +27,6 @@ spec:
- name: powervs-plugin
image: quay.io/powercloud/ibm-powervs-block-csi-driver:dev
imagePullPolicy: Always
- name: node-update-controller
image: quay.io/powercloud/ibm-powervs-block-csi-driver:dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, we need to avoid using quay.io/powercloud/ibm-powervs-block-csi-driver:dev

@mkumatag
Copy link
Member

/cc @Prajyot-Parab

mkumatag
mkumatag requested changes Mar 18, 2022
View reviewed changes
deploy/kubernetes/base/controller.yaml
Comment on lines +69 to +74
- name: metrics
containerPort: 8081
protocol: TCP
- name: healthz
containerPort: 8082
protocol: TCP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, then @Madhan-SWE can we add livenessProbe probe then.?

@Madhan-SWE
Copy link
Author

Madhan-SWE commented Mar 18, 2022 •
edited

@mkumatag liveness probe is already added as part of controller deployment yaml. I will explore about it and make necessary changes if needed.

@mkumatag
Copy link
Member

@mkumatag liveness probe is already added as part of controller deployment yaml. I will explore about it and make necessary changes if needed.

livenessProbe will be for each containers, hence this node controller is a new pod and we need to add this for checking the health of the container.

@Madhan-SWE
Copy link
Author

@mkumatag liveness probe is already added as part of controller deployment yaml. I will explore about it and make necessary changes if needed.

livenessProbe will be for each containers, hence this node controller is a new pod and we need to add this for checking the health of the container.

liveness probe is added. Please check if the values of failureThreshold, initialDelaySeconds, timeoutSeconds, periodSeconds are looks good to you.

mkumatag
mkumatag approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhan-SWE, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Madhan-SWE,mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e2a26df into kubernetes-sigs:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add node update controller to the deployments
5 participants
@Madhan-SWE @mkumatag @k8s-ci-robot @Prajyot-Parab @rcmadhankumar