ProviderID based changes added #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
approved
|
/hold until testing is completed on provider id added OCP cluster. |
k8s-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
/unhold manually created and pushed image, tested with sample workload and scale tests. |
Madhan-SWE
force-pushed
the
provideridchanges
branch
from
b9a1700
to
c424285
Compare
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@mkumatag can you review this? |
mkumatag
requested changes
Mar 23, 2022
mkumatag
requested changes
Mar 25, 2022
Madhan-SWE
force-pushed
the
provideridchanges
branch
from
d6e7e3f
to
865f47a
Compare
mkumatag
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
/approve
/lgtm
/hold for others to review
@Madhan-SWE feel free to remove hold when others finish reviewing the code
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhan-SWE, mkumatag, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
ProviderID based changes added.
Node labels based changes removed.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: