Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kustomization added #34

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Kustomization added #34

merged 1 commit into from
Dec 7, 2021

Conversation

Madhan-SWE
Copy link

Fixes: #7

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 7, 2021
@Madhan-SWE
Copy link
Author

@mkumatag can you review this?

mkumatag
mkumatag requested changes Dec 7, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment, otherwise lgtm

deploy/kubernetes/overlays/dev/master_image.yaml Outdated Show resolved Hide resolved
@mkumatag
Copy link
Member

mkumatag commented Dec 7, 2021

and also wondering if any instruction or makefile target is required for calling kustomize

@Madhan-SWE
Copy link
Author

and also wondering if any instruction or makefile target is required for calling kustomize

Checked few random csi driver code from the list: https://kubernetes-csi.github.io/docs/drivers.html

All of them are using make file to
- build driver
- create image
- generate mock
- go fmt, go vet, glint

But, when it comes to deployment they are always using Kubectl.

mkumatag
mkumatag approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhan-SWE, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 7, 2021
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit b83198b into kubernetes-sigs:main Dec 7, 2021
@Madhan-SWE Madhan-SWE mentioned this pull request Feb 18, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use kustomize
4 participants
@Madhan-SWE @mkumatag @ppc64le-cloud-bot @rcmadhankumar