Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module name changed to sigs.k8s.io/ibm-powervs-block-csi-driver #75

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

Madhan-SWE
Copy link

  • Module name changed to sigs.k8s.io/ibm-powervs-block-csi-driver
  • Internal names changed from powervs-csi-driver to ibm-powervs-block-csi-driver

Other fix in Makefile :

  • The Version for the image was hardcoded as latest earlier. Now changed as per variable VERSION

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 5, 2022
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2022
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhan-SWE, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2022
@mkumatag mkumatag merged commit 51e4e22 into kubernetes-sigs:main Jan 5, 2022
@Rajalakshmi-Girish
Copy link
Contributor

Rajalakshmi-Girish commented Jan 5, 2022

Even This PR had 404 error:

{"base-sha":"2d09bae6b49d120410c6b15a534846aa0eb867f9","branch":"main","component":"tide","controller":"sync","error":"status code 404 not one of [200 405 409], body: {\"message\":\"Not Found\",\"documentation_url\":\"https://docs.github.com/rest/reference/pulls#merge-a-pull-request\"}","file":"prow/tide/tide.go:1247","func":"k8s.io/test-infra/prow/tide.(*Controller).mergePRs","level":"debug","merge-targets":[75],"msg":"Merge failed.","org":"ppc64le-cloud","pr":75,"repo":"ibm-powervs-block-csi-driver","severity":"debug","sha":"95e5af69171a13d5b36a5d7e0f92c2e4c0085488","time":"2022-01-05T03:39:38Z"}

@mkumatag But didn't see this for #73

yussufsh pushed a commit to yussufsh/ibm-powervs-block-csi-driver that referenced this pull request Mar 8, 2024
MULTIARCH-4363: Rebase with upstream: go modules updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants