Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce the use of a supported Packer version #1379

Closed
AverageMarcus opened this issue Jan 19, 2024 · 4 comments · Fixed by #1383
Closed

Enforce the use of a supported Packer version #1379

AverageMarcus opened this issue Jan 19, 2024 · 4 comments · Fixed by #1383
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@AverageMarcus
Copy link
Member

Is your feature request related to a problem? Please describe.

We're unable to support Packer v1.10.0+ due to #1246. At time of writing, the latest version of Packer that we support is v1.9.5 and is what is installed if Packer isn't found on the machine.

But if Packer v1.10+ is found on the machine image-builder will just happily attempt to use that version which can then lead to issues such as #1378

Describe the solution you'd like
We should restrict the version used and if v1.10+ is found we should still download v1.9.5. We'll need to update the Makefile also to make sure if uses the locally downloaded binary instead of the system-wide version of Packer.

Describe alternatives you've considered
Alternatively we could not download the version and instead show an error to the user but this means the user then needs to figure out how to downgrade their version.

Additional context
Add any other context or screenshots about the feature request here.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 19, 2024
@kranurag7
Copy link
Contributor

/assign

I'll attempt hacking on this during the weekend.

@sriramandev
Copy link
Contributor

@kranurag7 Are you still working on this or should can I pick this up from where you left?

@kranurag7
Copy link
Contributor

@kranurag7 Are you still working on this or should can I pick this up from where you left?

I was not able to give time to fix the failing tests on the PR. @sriramandev You can work on this.

You can take my PR as a base or create a new one. (ping me once if you've the PR ready, I'll close my PR)

/unassign

@kranurag7
Copy link
Contributor

@sriramandev I added one commit (e66f4bf) which should be fixing the failing tests on the PR.
If you already started working on this, let me know I'll close mine as said above. If not, a review would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants