Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin packer version to 1.9.5 #1383

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

kranurag7
Copy link
Contributor

if packer version is greater than 1.9.5 in semver terms then downgrade packer.

Fixes #1379

with centos container

docker run --rm -it centos:latest sh
# put hack/utils.sh & hack/ensure-packer.sh and +x permissions. 
sh-4.4# ./packer.sh 
Packer is already installed, checking version...
unexpected packer found

with 1.10.0 version of packer

$ ./hack/ensure-packer.sh
Packer is already installed, checking version...
unsupported packer version (1.10.0) found
current packer version: 1.10.0 is not supported
Downgrading packer to 1.9.5
Installing packer v1.9.5 in .local/bin
packer_1.9.5_linux_amd64.zip: OK
Archive:  packer_1.9.5_linux_amd64.zip
  inflating: packer

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Additional context
Add any other context for the reviewers

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @kranurag7. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 27, 2024
@mboersma mboersma added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 1, 2024
@mboersma
Copy link
Contributor

mboersma commented May 1, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 1, 2024
@mboersma
Copy link
Contributor

mboersma commented May 6, 2024

I'm seeing this in the logs:

hack/ensure-packer.sh
Packer is already installed, checking version...
make: *** [Makefile:61: deps-common] Error 141

@kranurag7
Copy link
Contributor Author

I'm seeing this in the logs:

hack/ensure-packer.sh
Packer is already installed, checking version...
make: *** [Makefile:61: deps-common] Error 141

Hey. sorry for being late here and because of that the patch was open for a while now. :(
w.r.t. this, I changed the following and I think this should be good now. (thanks to set -x 🙃)

-   existing_packer_version=$(packer version | head -1 | cut -d 'v' -f 2)
+   existing_packer_version=$(packer version | head -1 | cut -d 'v' -f 2; exit 0)

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kranurag7 could you squash the commits into one and force-push?

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2024
@mboersma
Copy link
Contributor

mboersma commented Jun 4, 2024

/assign @AverageMarcus @drew-viles

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2024
@drew-viles
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drew-viles

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2024
@drew-viles
Copy link
Contributor

/hold

Actually @kranurag7 can you resquash the commits again please?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2024
if packer version is greater than 1.9.5 in semver terms then downgrade packer.

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Copy link
Member

@AverageMarcus AverageMarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I'll leave it to @drew-viles to unhold :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2024
@drew-viles
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2024
@drew-viles
Copy link
Contributor

Sorted. Thanks for this and your patience with us! @kranurag7

@k8s-ci-robot k8s-ci-robot merged commit 8b7b506 into kubernetes-sigs:main Jun 7, 2024
9 checks passed
@kranurag7 kranurag7 deleted the kr/pin-packer-version branch June 7, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce the use of a supported Packer version
5 participants