Fix ansible SSH not connecting

[agtogna]

What this PR does / why we need it:

Fix Ansible SSH not connecting because the image uses an ssh-rsa key which is disabled by default in recent OpenSSH.

Ansible SSH, since recent OpenSSH has disabled the usage of "old" ssh-rsa keys, cannot connect to the image; the Ubuntu 20.04 image still uses ssh-rsa.

make build-node-ova-vsphere-ubuntu-2004

  vsphere:
   vsphere: PLAY [all] *********************************************************************
==> vsphere: failed to handshake
   vsphere:
   vsphere: TASK [Gathering Facts] *********************************************************
   vsphere: fatal: [default]: UNREACHABLE! => {"changed": false, "msg": "Failed to connect to the host via ssh: Unable to negotiate with 127.0.0.1 port 43161: no matching host key type found. Their offer: ssh-rsa", "unreachable": true}
   vsphere:
   vsphere: PLAY RECAP *********************************************************************
   vsphere: default                    : ok=0    changed=0    unreachable=1    failed=0    skipped=0    rescued=0    ignored=0
   vsphere:

This PR adds the correct options to ANSIBLE_SSH_ARGS to have Ansible connect.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: agtogna-nc / name: Alessandro Giorgio Togna (4cf93d7)

[k8s-ci-robot]

Hi @agtogna-nc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @agtogna-nc!

It looks like this is your first PR to kubernetes-sigs/image-builder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/image-builder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: agtogna-nc
Once this PR has been reviewed and has the lgtm label, please assign gab-satchi for approval by writing /assign @gab-satchi in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• images/capi/packer/ova/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kkeshavamurthy]

@agtogna Can you add the versions which is causing this issue so that I can reproduce it.

[agtogna]

here they are:

packer --version
1.8.4

ansible --version
ansible [core 2.11.5] 
  config file = /home/agtogna/workdir/image-builder/images/capi/ansible.cfg
  configured module search path = ['/home/agtogna/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/agtogna/.local/lib/python3.10/site-packages/ansible
  ansible collection location = /home/agtogna/.ansible/collections:/usr/share/ansible/collections
  executable location = /home/agtogna/.local/bin/ansible
  python version = 3.10.6 (main, Nov  2 2022, 18:53:38) [GCC 11.3.0]
  jinja version = 3.1.2
  libyaml = True

[Meecr0b]

related to #905
_{Dennis Lerch dennis.lerch@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, Provider Information}

[invidian]

See also #907.

[kkeshavamurthy]

@agtogna Seems like there's an issue and a PR open to fix this. Do we still need this PR or can it be closed?

[invidian]

I've opened #1035 which will close this PR if it gets merged, as it provides more broader fixes and also includes changes from this PR.

[agtogna]

@agtogna Seems like there's an issue and a PR open to fix this. Do we still need this PR or can it be closed?

It can be closed, I'll follow #1035 instead.
Thank you.