-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
images/capi/packer/config/ansible-args.json: remove ssh-rsa workaround #1224
images/capi/packer/config/ansible-args.json: remove ssh-rsa workaround #1224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for following up on this @invidian!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In commit 76671ca we added a workaround for packer-plugin-ansible not supporting keys other than ssh-rsa, which broke building images for clients using newer versions of OpenSSH. This should no longer be needed with the latest version of packer ansible plugin: hashicorp/packer-plugin-ansible#69 (comment) Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
893ac17
to
74f31d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
In commit 76671ca we added a workaround for packer-plugin-ansible not supporting keys other than ssh-rsa, which broke building images for clients using newer versions of OpenSSH.
This should no longer be needed with the latest version of packer ansible plugin:
hashicorp/packer-plugin-ansible#69 (comment)
Additional context
This is a follow up to issue #905.