Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instruction to build DHCP configured images #1455

Merged
merged 1 commit into from
May 2, 2024
Merged

Add instruction to build DHCP configured images #1455

merged 1 commit into from
May 2, 2024

Conversation

Karthik-K-N
Copy link
Contributor

Change description

packer-plugin-powervs now supports building DHCP enabled images. A new flag was introduced to facilitate this.
This PR updates document to add the new flag and its usage.

Related issues

  • Fixes #

Additional context

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 30, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 30, 2024
mkumatag
mkumatag approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2024
@mkumatag
Copy link
Member

/hold
to cut a new release with the enhancement mentioned.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024
@mkumatag
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024
@mkumatag
Copy link
Member

lets bump the packer package version as well

released the latest version here - https://github.com/ppc64le-cloud/packer-plugin-powervs/releases/tag/v0.2.4

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2024
Karthik-K-N
Karthik-K-N commented May 1, 2024
View reviewed changes
images/capi/hack/ensure-powervs.sh
@@ -31,7 +31,7 @@ if ! (${SED} --version 2>&1 | grep -q GNU); then
exit 1
fi

_version="0.2.1"
_version="0.2.4"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to latest release which contains the dhcp related changed.

@Karthik-K-N
Copy link
Contributor Author

lets bump the packer package version as well

released the latest version here - https://github.com/ppc64le-cloud/packer-plugin-powervs/releases/tag/v0.2.4

Updated https://github.com/kubernetes-sigs/image-builder/pull/1455/files#r1585843331

@mboersma mboersma added the kind/documentation Categorizes issue or PR as related to documentation. label May 1, 2024
mkumatag
mkumatag approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2024
AverageMarcus
AverageMarcus reviewed May 2, 2024
View reviewed changes
Copy link
Member

@AverageMarcus AverageMarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AverageMarcus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 74a61b2 into kubernetes-sigs:main May 2, 2024
8 checks passed
@Karthik-K-N Karthik-K-N deleted the update-instructions branch May 2, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AverageMarcus AverageMarcus AverageMarcus left review comments

@mkumatag mkumatag mkumatag approved these changes

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@AverageMarcus AverageMarcus

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Karthik-K-N @mkumatag @k8s-ci-robot @AverageMarcus @mboersma