New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 1.7 ansible galaxy package for Windows #657
Use 1.7 ansible galaxy package for Windows #657
Conversation
/retest |
@codenrhoden @kkeshavamurthy OVA test is failing with
Same failure is happening in other PRs too |
@jsturtevant are you able to fix up your commits? looks like one of them does nothing but a space? otherwise lgtm |
/test pull-container-image-build I'm confused when I see the title of this PR saying it's installing Ansible 2.10, but the code is installing ansible.windows 1.7. Ansible has so many versions floating around now. =) I get what's happening, but still. I think at some point we should explore moving to Ansible 4.x (with ansible-core 2.11.x), and maybe taking the ansible-core route with only installing the modules we need to reduce sizes. |
FWIW, I fixed a related issue that @jsturtevant and I were working on by upgrading from ansible 2.10.x to 4.2.0. It builds at least the Azure images without any problems, so there's one data point in favor. |
/lgtm |
/lgtm @jsturtevant please fix the commits and ping me when it's ready for approve |
b8c8d2b
to
424449d
Compare
@jsturtevant: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jsturtevant The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Ansible windows package broke win_templates in ansible/ansible#74887 and has been fixed in the package which is not avaliable via standard 2.10.11 ansible package.
This ensures we have the latest windows package with the fixes
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #624
Additional context
Add any other context for the reviewers
/sig windows
/cc @perithompson @mboersma