Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1.7 ansible galaxy package for Windows #657

Conversation

jsturtevant
Copy link
Contributor

What this PR does / why we need it:

Ansible windows package broke win_templates in ansible/ansible#74887 and has been fixed in the package which is not avaliable via standard 2.10.11 ansible package.

This ensures we have the latest windows package with the fixes

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #624

Additional context
Add any other context for the reviewers

/sig windows
/cc @perithompson @mboersma

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2021
@perithompson
Copy link
Contributor

/retest

@CecileRobertMichon
Copy link
Contributor

@codenrhoden @kkeshavamurthy OVA test is failing with

--> vsphere: ServerFaultCode: Cannot complete login due to an incorrect user name or password.

Same failure is happening in other PRs too

@perithompson
Copy link
Contributor

@jsturtevant are you able to fix up your commits? looks like one of them does nothing but a space? otherwise lgtm

@codenrhoden
Copy link
Contributor

/test pull-container-image-build

I'm confused when I see the title of this PR saying it's installing Ansible 2.10, but the code is installing ansible.windows 1.7.

Ansible has so many versions floating around now. =) I get what's happening, but still.

I think at some point we should explore moving to Ansible 4.x (with ansible-core 2.11.x), and maybe taking the ansible-core route with only installing the modules we need to reduce sizes.

@mboersma
Copy link
Contributor

mboersma commented Jul 20, 2021

I think at some point we should explore moving to Ansible 4.x

FWIW, I fixed a related issue that @jsturtevant and I were working on by upgrading from ansible 2.10.x to 4.2.0. It builds at least the Azure images without any problems, so there's one data point in favor.

@codenrhoden
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@CecileRobertMichon
Copy link
Contributor

/lgtm

@jsturtevant please fix the commits and ping me when it's ready for approve

@jsturtevant jsturtevant force-pushed the update-ansible-windows-version branch from b8c8d2b to 424449d Compare July 20, 2021 16:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@jsturtevant jsturtevant changed the title Update ansible windows version to use latest 2.10 ansible version Use 1.7 ansible galaxy pacakge for Windows Jul 20, 2021
@k8s-ci-robot
Copy link
Contributor

@jsturtevant: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-ova-all 424449d link /test pull-ova-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@CecileRobertMichon
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2021
@jsturtevant jsturtevant changed the title Use 1.7 ansible galaxy pacakge for Windows Use 1.7 ansible galaxy package for Windows Jul 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1df28a8 into kubernetes-sigs:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants