qemu,raw: Mask sshd during bootstrap #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flatcar ships with sshd enabled by default. Installing Flatcar entails booting into Flatcar from an ISO and running the installation command. Packer treats the availability of the SSH port as an indication that the OS installation is done. To address this, a static wait time is appended to the Flatcar boot command, which means there is a potential race between the installation script and Packer. This leads to occasional Packer errors in Flatcar builds. Mask sshd during bootstrap. When the installation completes, the VM is rebooted from disk and then sshd is enabled again automatically. Also remove the wait as it's no longer necessary because we can rely on the built-in ssh_timeout Packer parameter like other distros do. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codenrhoden, johananl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
johananl
added a commit
to kinvolk/image-builder
that referenced
this pull request
May 26, 2022
This is a similar change to kubernetes-sigs#893 - see this PR for more info. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
johananl
added a commit
to kinvolk/image-builder
that referenced
this pull request
Jul 7, 2022
This is a similar change to kubernetes-sigs#893 - see this PR for more info. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
johananl
added a commit
to kinvolk/image-builder
that referenced
this pull request
Jul 8, 2022
This is a similar change to kubernetes-sigs#893 - see this PR for more info. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
johananl
added a commit
to kinvolk/image-builder
that referenced
this pull request
Jul 14, 2022
This is a similar change to kubernetes-sigs#893 - see this PR for more info. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
johananl
added a commit
to kinvolk/image-builder
that referenced
this pull request
Jul 28, 2022
This is a similar change to kubernetes-sigs#893 - see this PR for more info. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a fix to a race in the Flatcar installation process on the QEMU and raw targets.
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #892
Additional context
To test this PR, ensure the following build succeeds: