Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golang to 1.22 #471

Merged
merged 2 commits into from Mar 25, 2024
Merged

Conversation

kannon92
Copy link
Contributor

Seems like a lot of kube dependencies are upgrading to 1.22 with kube 1.30 coming down the pipe.

Let's bump this to 1.22. We just bumped our CI to run with 1.22 image.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2024
Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit 621b3b9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/6601b28e549f5a00082a81e5

@danielvegamyhre
Copy link
Contributor

/retest

@kannon92
Copy link
Contributor Author

hmm. maybe we can't do this yet.

@kannon92
Copy link
Contributor Author

/hold

Something is not right here.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2024
@danielvegamyhre
Copy link
Contributor

danielvegamyhre commented Mar 22, 2024

/hold

Something is not right here.

1.593 sigs.k8s.io/jobset/pkg/util/collections: cannot compile Go 1.22 code

Weird, bumping 1.22 works me locally, everything builds fine. Did it work locally for you as well?

If so it must be a CI env issue, will need to investigate

@kannon92
Copy link
Contributor Author

yea I wonder if the test-infra image is using 1.21.0.

@kannon92
Copy link
Contributor Author

I have kubernetes/test-infra#32302 to see if that will fix the PR.

@kannon92
Copy link
Contributor Author

Opened up kubernetes-sigs/kueue#1895 to see.

This seems to work so please review kubernetes/test-infra#32302 when you get a chance.

@kannon92
Copy link
Contributor Author

/retest

1 similar comment
@kannon92
Copy link
Contributor Author

/retest

@kannon92
Copy link
Contributor Author

/hold cancel

Found out that kueue parametrizes BUILDER_IMAGE

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2024
@danielvegamyhre
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8e15bae into kubernetes-sigs:main Mar 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants