Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding request counter threshold #384

Merged
merged 1 commit into from Jul 31, 2021
Merged

Adding request counter threshold #384

merged 1 commit into from Jul 31, 2021

Conversation

tylerferrara
Copy link
Contributor

@tylerferrara tylerferrara commented Jul 30, 2021 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

This change introduces a threshold for resettable request counters. The request counter will fire a logrus.Warn statement if it observes it's requests exceed that threshold. Non-resettable request counters will explicitly ignore any thresholds, as they indefinitely increment. Now, we can easily query GCP logs for these warning messages to determine if network usage is high.

Which issue(s) this PR fixes:

Part of #353 #358

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Create request counter thresholds which warn when number of requests have been exceeded.

cc: @listx @amwat @justaugustus @kubernetes-sigs/release-engineering

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects labels Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. wg/k8s-infra labels Jul 30, 2021
@tylerferrara tylerferrara changed the title Adding request counter threshold [WIP] Adding request counter threshold Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2021
This was referenced Jul 30, 2021
Closed
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2021
@tylerferrara tylerferrara changed the title [WIP] Adding request counter threshold Adding request counter threshold Jul 30, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2021
listx
listx reviewed Jul 30, 2021
View reviewed changes
legacy/reqcounter/reqcounter.go Outdated Show resolved Hide resolved
legacy/reqcounter/reqcounter_test.go Outdated Show resolved Hide resolved
legacy/reqcounter/reqcounter_test.go Outdated Show resolved Hide resolved
legacy/reqcounter/reqcounter_test.go Outdated Show resolved Hide resolved
legacy/reqcounter/reqcounter.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2021
listx
listx reviewed Jul 31, 2021
View reviewed changes
Copy link
Contributor

@listx listx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

legacy/reqcounter/reqcounter.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: listx, tylerferrara

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2021
@k8s-ci-robot k8s-ci-robot merged commit af23327 into kubernetes-sigs:master Jul 31, 2021
@tylerferrara tylerferrara mentioned this pull request Jul 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@listx listx listx left review comments

@hasheddan hasheddan Awaiting requested review from hasheddan

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@listx listx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tylerferrara @k8s-ci-robot @listx