-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Webhooks in Favor of OpenAPI/CEL CRD Validation #103
Comments
We haven't gone through the exercise of using builtin CRD validation. The defaults are provider specific. See: https://github.com/aws/karpenter/blob/main/pkg/apis/v1alpha5/provisioner.go#L45. I'd be curious to see if you could replace the validation webhooks. |
@ellistarn can you please elaborate on that? I believe the defaulting webhook could also be avoided by adding |
Interesting ideas. Would you be interested in contributing this? |
@ellistarn sure. |
Sure thing! |
Labeled for closure due to inactivity in 10 days. |
Labeled for closure due to inactivity in 10 days. |
Kubernetes supports CEL for CRD validation. We should investigate this along with the other validations that are supported natively by the Open API specs (like defaults, minimum, maximums, etc.) |
Hi,
I'm trying to understand the benefits which the Karpenter webhooks provide.
Looking at the validating webhook code it seems that the same validation could be done via the CRD schema.
The defaulting webhook doesn't seem to do anything at all. In addition, you can add default values to the CRD schema.
The text was updated successfully, but these errors were encountered: