Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Update options defaults for v1beta1 #821

Merged

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Nov 24, 2023

Closes #103
Closes #727
Closes #726

Description

This PR implements a planned breaking change for the v0.33 beta upgrade which involves setting the following new defaults for the beta version while also dropping the settings merge logic:

  1. The Drift feature gate is now enabled by default.
  2. The webhooks are now disabled by default.
  3. The global log level is now set to info by default if not overridden in the log configuration file

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
@jonathan-innis jonathan-innis changed the title BREAKING CHANGE: Update options defaults for v1beta1 [DRAFT] BREAKING CHANGE: Update options defaults for v1beta1 Nov 24, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 24, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2023
@coveralls
Copy link

coveralls commented Nov 24, 2023

Pull Request Test Coverage Report for Build 7014120007

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 79.553%

Totals Coverage Status
Change from base Build 7013365339: -0.02%
Covered Lines: 8015
Relevant Lines: 10075

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2023
@jonathan-innis jonathan-innis marked this pull request as ready for review November 28, 2023 04:43
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2023
@engedaam
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6aabe5c into kubernetes-sigs:main Nov 28, 2023
8 checks passed
@jonathan-innis jonathan-innis changed the title [DRAFT] BREAKING CHANGE: Update options defaults for v1beta1 BREAKING CHANGE: Update options defaults for v1beta1 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
4 participants