-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: Update options defaults for v1beta1 #821
Merged
k8s-ci-robot
merged 2 commits into
kubernetes-sigs:main
from
jonathan-innis:update-beta-defaults
Nov 28, 2023
Merged
BREAKING CHANGE: Update options defaults for v1beta1 #821
k8s-ci-robot
merged 2 commits into
kubernetes-sigs:main
from
jonathan-innis:update-beta-defaults
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
00f6948
to
c4dd506
Compare
c4dd506
to
278dc4a
Compare
Pull Request Test Coverage Report for Build 7014120007
💛 - Coveralls |
278dc4a
to
20d9f18
Compare
20d9f18
to
222b6be
Compare
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103
Closes #727
Closes #726
Description
This PR implements a planned breaking change for the
v0.33
beta upgrade which involves setting the following new defaults for the beta version while also dropping the settings merge logic:info
by default if not overridden in the log configuration fileHow was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.