Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize the names of all config maps and secrets through the template #727

Closed
spereverziev opened this issue Feb 14, 2023 · 3 comments · Fixed by #821
Closed

Parametrize the names of all config maps and secrets through the template #727

spereverziev opened this issue Feb 14, 2023 · 3 comments · Fixed by #821
Labels
good-first-issue Good for newcomers kind/feature Categorizes issue or PR as related to a new feature.

Comments

@spereverziev
Copy link

Tell us about your request

Today the values of config maps and secrets are hardcoded. As K8s doesn't have history api for config maps and secrets we want to customizing the names with version to be able to do a rollback.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

We need to have an ability to do an addon upgrade/rollback. We are not using helm.

Are you currently working around this issue?

No workaround

Additional Context

No response

Attachments

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@spereverziev spereverziev added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 14, 2023
@spereverziev spereverziev changed the title Parametrize all config map's and secret's name through the template Parametrize all config maps and secrets through the template Feb 14, 2023
@spereverziev spereverziev changed the title Parametrize all config maps and secrets through the template Parametrize the names of all config maps and secrets through the template Feb 14, 2023
@ellistarn ellistarn added the good-first-issue Good for newcomers label Feb 20, 2023
@ellistarn
Copy link
Contributor

Open minded to contributions here.

@f-palma
Copy link

f-palma commented Oct 13, 2023

Hi @ellistarn! I use karpenter and think it's great, so I'd like to contribute :) can I start with this issue?

@ellistarn
Copy link
Contributor

We're moving away from configmaps as part of beta, and using env vars aws/karpenter-provider-aws#4789 to solve this problem, among many others.

@njtran njtran transferred this issue from aws/karpenter-provider-aws Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants