Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate pkg/api from github.com/aws/karpenter #1

Merged
merged 1 commit into from
Oct 12, 2022
Merged

chore: Migrate pkg/api from github.com/aws/karpenter #1

merged 1 commit into from
Oct 12, 2022

Conversation

ellistarn
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

bwagner5
bwagner5 previously approved these changes Oct 12, 2022
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ellistarn ellistarn merged commit 9f28ba0 into kubernetes-sigs:main Oct 12, 2022
@ellistarn ellistarn deleted the apis branch October 12, 2022 21:42
fmuyassarov added a commit to fmuyassarov/karpenter that referenced this pull request Jun 5, 2024
Without bumping to 1.22.4 we will have the following issue:
Vulnerability kubernetes-sigs#1: GO-2024-2887
    Unexpected behavior from Is methods for IPv4-mapped IPv6 addresses in
    net/netip
  More info: https://pkg.go.dev/vuln/GO-2024-2887
  Standard library
    Found in: net/netip@go1.22.3
    Fixed in: net/netip@go1.22.4
    Example traces found:
      kubernetes-sigs#1: pkg/test/environment.go:101:31: test.NewEnvironment calls
		envtest.Environment.Start, which eventually calls netip.Addr.IsLoopback
      kubernetes-sigs#2: pkg/test/environment.go:101:31: test.NewEnvironment calls
		envtest.Environment.Start, which eventually calls netip.Addr.IsMulticast

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants