chore: Add queue depth metrics for provisioning and termination #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
jonathan-innis
force-pushed
the
add-queue-depth-metrics
branch
2 times, most recently
from
deab3d8
to
bca6d51
Compare
Pull Request Test Coverage Report for Build 8152913054Details
💛 - Coveralls |
engedaam
reviewed
Mar 4, 2024
| ) | ||
|
|
||
| var ( | ||
| schedulingSimulationDuration = prometheus.NewHistogramVec( |
There was a problem hiding this comment.
Should we add testing to ensure this metrics are working as expected?
jonathan-innis
force-pushed
the
add-queue-depth-metrics
branch
3 times, most recently
from
97926d4
to
b461789
Compare
jonathan-innis
force-pushed
the
add-queue-depth-metrics
branch
from
b461789
to
022e5d7
Compare
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
This changes adds the
karpenter_nodes_eviction_queue_depthandkarpenter_provisioner_scheduling_queue_depthto give metrics on the number of items that are currently in these queues. This will allow us to get better insight into how quickly we are processing through items and also to know if we are making progress.How was this change tested?
make presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.