-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add hardcoded utc prefix to crontab #1063
Conversation
Pull Request Test Coverage Report for Build 8148257585Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: engedaam, njtran The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Fixes #943
Description
Karpenter releases are built with UTC, but this adds a "TZ=UTC" prefix to valid schedules for budgets to ensure that the underlying cron library always parses the schedule in UTC time.
How was this change tested?
make apply with kwok and test different schedules.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.