Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add hardcoded utc prefix to crontab #1063

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Mar 4, 2024

Fixes #943

Description
Karpenter releases are built with UTC, but this adds a "TZ=UTC" prefix to valid schedules for budgets to ensure that the underlying cron library always parses the schedule in UTC time.

How was this change tested?
make apply with kwok and test different schedules.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 4, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2024
@coveralls
Copy link

coveralls commented Mar 4, 2024

Pull Request Test Coverage Report for Build 8148257585

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 81.024%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/node/termination/terminator/eviction.go 2 88.79%
Totals Coverage Status
Change from base Build 8145053360: 0.02%
Covered Lines: 8164
Relevant Lines: 10076

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2024
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@engedaam
Copy link
Contributor

engedaam commented Mar 4, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
@njtran njtran merged commit 831d3c6 into kubernetes-sigs:main Mar 4, 2024
4 of 12 checks passed
jigisha620 pushed a commit to jigisha620/karpenter that referenced this pull request Mar 5, 2024
k8s-ci-robot pushed a commit that referenced this pull request Mar 5, 2024
Co-authored-by: Nick Tran <10810510+njtran@users.noreply.github.com>
@njtran njtran deleted the utc branch March 5, 2024 17:45
njtran added a commit to njtran/karpenter that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the timezone for budgets only UTC
5 participants