perf: Reduce delete calls by checking DeletionTimestamp #1095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Check DeletionTimestamp when calling
Delete()
. If the DeletionTimestamp is already set, we don't need to callDelete()
again. I noticed that we were over-calling Delete() when I was looking at kube-apiserver audit logs for the termination flow.For instance, for a singe Node that was stuck terminating due to evictions for 5m, it had
176
calls to Delete() the NodeClaim.How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.