fix: Check node readiness before force terminating

[jonathan-innis]

Fixes #1100

Description

This change gates deletion of the NodeClaim and the force deletion of the Node based on the readiness of the Node. Today, we blindly delete the NodeClaim and Node if we get NotExists from the CloudProvider; however, we should also gate this based on the Node readiness and kubelet heartbeat to deal with potential inconsistency issues on the List() CloudProvider call.

This also lets the Registration liveness controller cleanup any NodeClaims that don't register in time, but allows the full 15m timeout to occur before terminating a NodeClaim that doesn't exist being returned from the CloudProvider List() call.

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coveralls]

Pull Request Test Coverage Report for Build 8277948745

Details

• 31 of 37 (83.78%) changed or added relevant lines in 3 files are covered.
• 4 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.1%) to 79.045%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controllers/node/termination/controller.go	10	11	90.91%
pkg/controllers/nodeclaim/garbagecollection/controller.go	8	10	80.0%
pkg/test/expectations/expectations.go	13	16	81.25%

Files with Coverage Reduction	New Missed Lines	%
pkg/test/expectations/expectations.go	2	95.59%
pkg/scheduling/requirements.go	2	97.98%

Totals
Change from base Build 8277948603:	0.1%
Covered Lines:	8291
Relevant Lines:	10489

---

💛 - Coveralls

[njtran]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jonathan-innis,njtran]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment