Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change type to hash on KubeReserved and SystemReserved #1141

Merged

Conversation

engedaam
Copy link
Contributor

Fixes #1080

Description

  • To allow drift to happen on the on KubeReserved and SystemReserved, we need to update the type to be a map[string]string so that we can hash on the values

How was this change tested?

  • make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2024
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 26, 2024
@coveralls
Copy link

coveralls commented Mar 26, 2024

Pull Request Test Coverage Report for Build 8486657056

Details

  • 11 of 13 (84.62%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 78.928%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1beta1/nodeclaim_validation.go 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/drift.go 2 90.63%
pkg/apis/v1beta1/nodeclaim_validation.go 2 90.59%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
Totals Coverage Status
Change from base Build 8483818355: -0.02%
Covered Lines: 8274
Relevant Lines: 10483

💛 - Coveralls

@engedaam engedaam force-pushed the stirng-kubeReserved-systemReserved branch from 2630b77 to 459be13 Compare March 26, 2024 23:31
@engedaam engedaam marked this pull request as ready for review March 26, 2024 23:31
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2024
@engedaam engedaam force-pushed the stirng-kubeReserved-systemReserved branch from 459be13 to b93d95c Compare March 26, 2024 23:58
hack/validation/kubelet.sh Outdated Show resolved Hide resolved
pkg/apis/v1beta1/nodeclaim_validation.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the stirng-kubeReserved-systemReserved branch from b93d95c to 4312af1 Compare March 29, 2024 23:41
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7654bd1 into kubernetes-sigs:main Mar 29, 2024
12 checks passed
@engedaam engedaam deleted the stirng-kubeReserved-systemReserved branch April 2, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

systemReserved and kubeReserved don't trigger drift
4 participants