Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Get the GVK of the supported NodeClasses as part of the CloudProvider interface #1146

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • For Karpenter to be able to query the APIServer for NodeClass, we will need to know the Kind, Version and Group of the nodeclass supported by the cloudprovider.
  • Adding GetSupportedNodeClasses to get all the NodeClasses used by a cloudprovider

How was this change tested?

  • N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 29, 2024
@engedaam engedaam changed the title feat: Get the supported NodeClass GVK as part of the CloudProvider interface feat: Get the supported NodeClasses GVK as part of the CloudProvider interface Mar 29, 2024
@engedaam engedaam changed the title feat: Get the supported NodeClasses GVK as part of the CloudProvider interface feat: Get the GVK of the supported NodeClasses as part of the CloudProvider interface Mar 29, 2024
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2024
@coveralls
Copy link

coveralls commented Mar 29, 2024

Pull Request Test Coverage Report for Build 8483611623

Details

  • 7 of 13 (53.85%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 78.882%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kwok/cloudprovider/cloudprovider.go 0 3 0.0%
pkg/cloudprovider/fake/cloudprovider.go 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/node/termination/terminator/eviction.go 2 88.89%
Totals Coverage Status
Change from base Build 8456314668: -0.05%
Covered Lines: 8266
Relevant Lines: 10479

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot merged commit 3d51e28 into kubernetes-sigs:main Mar 29, 2024
12 checks passed
@engedaam engedaam deleted the supported-nodeclass branch March 29, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants