Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add operator status condition metrics #1388

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Jul 3, 2024

Fixes #N/A

Description

Add operator_status_condition_count and operator_status_condition_transition_seconds from operatorpkg for NodePool and NodeClaim

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2024
@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9774979429

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 78.651%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/controllers.go 0 1 0.0%
pkg/operator/operator.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/operator/operator.go 1 4.38%
pkg/controllers/node/termination/terminator/eviction.go 2 89.09%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
Totals Coverage Status
Change from base Build 9772878439: -0.1%
Covered Lines: 8591
Relevant Lines: 10923

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2024
@jonathan-innis jonathan-innis force-pushed the operator-status-condition-metrics branch from cc90cf5 to 6ba9ac6 Compare July 9, 2024 22:26
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2024
@jonathan-innis jonathan-innis force-pushed the operator-status-condition-metrics branch from 6ba9ac6 to 6be66c1 Compare July 9, 2024 22:31
@coveralls
Copy link

coveralls commented Jul 9, 2024

Pull Request Test Coverage Report for Build 9870150574

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 78.297%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/controllers.go 0 2 0.0%
Totals Coverage Status
Change from base Build 9868007030: 0.07%
Covered Lines: 8947
Relevant Lines: 11427

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the operator-status-condition-metrics branch from 6be66c1 to 7c90fb2 Compare July 9, 2024 23:12
@jonathan-innis jonathan-innis force-pushed the operator-status-condition-metrics branch from 7c90fb2 to 05d6c2d Compare July 10, 2024 07:40
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jonathan-innis,njtran]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 94f9efb into kubernetes-sigs:main Jul 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants