Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove runtime update of karpenter-global-settings #174

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Jan 24, 2023

Fixes #154

Description

  • Remove runtime update of karpenter-global-settings
  • Creates a settings.Injectable interface that injects settings into the context
  • Preps and allows us to move other settings into the CM if we choose that are currently sitting inside of the CLI arguments

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis force-pushed the remove-runtime-settings-changes branch 5 times, most recently from dd133eb to fb9354f Compare January 24, 2023 21:08
@coveralls
Copy link

coveralls commented Jan 24, 2023

Pull Request Test Coverage Report for Build 4017778981

  • 51 of 58 (87.93%) changed or added relevant lines in 6 files are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 79.29%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/operator/injection/fake/settings.go 9 10 90.0%
pkg/operator/injection/injection.go 22 24 91.67%
pkg/operator/operator.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/provisioner.go 2 85.56%
pkg/controllers/provisioning/batcher.go 3 70.0%
pkg/test/expectations/expectations.go 7 92.89%
Totals Coverage Status
Change from base Build 4017760969: 0.1%
Covered Lines: 6390
Relevant Lines: 8059

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the remove-runtime-settings-changes branch 5 times, most recently from 68b3120 to 4604b48 Compare January 24, 2023 21:32
@jonathan-innis jonathan-innis marked this pull request as ready for review January 24, 2023 21:33
@jonathan-innis jonathan-innis requested a review from a team as a code owner January 24, 2023 21:33
@jonathan-innis jonathan-innis changed the title chore: Remove runtime resolution of configMap settings chore: Remove runtime update of configMap settings Jan 24, 2023
@jonathan-innis jonathan-innis changed the title chore: Remove runtime update of configMap settings chore: Remove runtime update of karpenter-global-settings Jan 24, 2023
@jonathan-innis jonathan-innis force-pushed the remove-runtime-settings-changes branch 2 times, most recently from 070e3c8 to d0055a2 Compare January 24, 2023 21:59
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure to document in a comment somewhere why we moved to static settings from dynamic settings?

ellistarn
ellistarn previously approved these changes Jan 25, 2023
pkg/apis/settings/injectable.go Show resolved Hide resolved
@jonathan-innis jonathan-innis enabled auto-merge (squash) January 26, 2023 18:20
@jonathan-innis jonathan-innis merged commit bd476c4 into kubernetes-sigs:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings should not dynamically update at runtime
3 participants