Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA linting #652

Merged

Conversation

jonathan-innis
Copy link
Member

Fixes #N/A

Description

Add linting for GHA workflows
actionlint does not currently support composite action checking but this feature appears to be in the works (rhysd/actionlint#366). When that feature is implemented, we could also add that feature to our CI

How was this change tested?

actionlint -oneline

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner October 31, 2023 18:12
@jonathan-innis jonathan-innis enabled auto-merge (squash) October 31, 2023 18:12
@jonathan-innis jonathan-innis force-pushed the enable-actionlint branch 2 times, most recently from 863bed2 to a2aaa22 Compare November 1, 2023 04:32
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 44503bc into kubernetes-sigs:main Nov 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants