Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove v1alpha5 from provisioning #653

Merged
merged 1 commit into from
Nov 1, 2023
Merged

chore: remove v1alpha5 from provisioning #653

merged 1 commit into from
Nov 1, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Nov 1, 2023

Fixes #N/A

Description
Removes provisioners and machines from the provisioning controller.

How was this change tested?
make verify and make apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner November 1, 2023 05:52
@njtran njtran requested a review from bwagner5 November 1, 2023 05:52
@coveralls
Copy link

coveralls commented Nov 1, 2023 •
edited

Pull Request Test Coverage Report for Build 6716238006

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 86 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.8%) to 79.808%
Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 1 88.65%
pkg/apis/v1alpha5/limits.go 2 80.0%
pkg/controllers/provisioning/provisioner.go 2 77.96%
pkg/controllers/state/statenode.go 2 93.47%
pkg/controllers/provisioning/scheduling/topology.go 7 85.28%
pkg/controllers/provisioning/scheduling/nodeclaimtemplate.go 22 77.32%
pkg/apis/v1alpha5/zz_generated.deepcopy.go 50 39.48%
Totals Coverage Status
Change from base Build 6716121615: -0.8%
Covered Lines: 8794
Relevant Lines: 11019
💛 - Coveralls

@njtran njtran enabled auto-merge (squash) November 1, 2023 06:21
jonathan-innis
jonathan-innis approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran merged commit 21ab254 into kubernetes-sigs:main Nov 1, 2023
6 checks passed
@njtran njtran deleted the removeBeforeFive branch November 1, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@njtran @coveralls @jonathan-innis