Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove machines from node termination and topology test #656

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Nov 1, 2023

Fixes #N/A

Description
Final removal of all v1alpha5 from controllers

How was this change tested?
make verify and make apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner November 1, 2023 20:42
@njtran njtran requested a review from engedaam November 1, 2023 20:42
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran enabled auto-merge (squash) November 1, 2023 20:45
@njtran njtran merged commit dde500e into kubernetes-sigs:main Nov 1, 2023
6 checks passed
@njtran njtran deleted the removeRemainder branch December 26, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants