Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove v1alpha5 utils #658

Merged
merged 2 commits into from
Nov 2, 2023
Merged

chore: remove v1alpha5 utils #658

merged 2 commits into from
Nov 2, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Nov 2, 2023 •
edited

Fixes #N/A

Description
Remove all v1alpha5 util functions. Any dependent repos that use the machine util functions will need to remove the reference to the function.

How was this change tested?
make presubmit && make apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner November 2, 2023 00:33
@njtran njtran requested a review from tzneal November 2, 2023 00:33
@coveralls
Copy link

coveralls commented Nov 2, 2023 •
edited

Pull Request Test Coverage Report for Build 6726795587

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • 89 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+1.2%) to 79.529%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/events/events.go 1 89.16%
pkg/apis/v1alpha5/provisioner.go 6 44.44%
pkg/apis/v1alpha5/machine_status.go 9 0.0%
pkg/test/machine.go 15 0.0%
pkg/utils/nodeclaim/nodeclaim.go 26 61.28%
pkg/apis/v1alpha5/zz_generated.deepcopy.go 32 18.44%
Totals Coverage Status
Change from base Build 6726543875: 1.2%
Covered Lines: 8271
Relevant Lines: 10400
💛 - Coveralls

jonathan-innis
jonathan-innis approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran merged commit 079e3ce into kubernetes-sigs:main Nov 2, 2023
6 checks passed
@rakechill rakechill mentioned this pull request Dec 21, 2023
Merged
3 tasks
@njtran njtran deleted the utils branch December 26, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@njtran @coveralls @jonathan-innis