Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove machine taint code #762

Merged
merged 10 commits into from
Nov 6, 2023
Merged

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Nov 6, 2023

Fixes #N/A

Description
Removes logic that uses the unschedulable taint for Machines

How was this change tested?
make presubmit && make apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner November 6, 2023 02:51
@njtran njtran requested a review from bwagner5 November 6, 2023 02:51
@coveralls
Copy link

coveralls commented Nov 6, 2023

Pull Request Test Coverage Report for Build 6776988415

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 16 of 19 (84.21%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 79.626%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/disruption/controller.go 10 13 76.92%
Totals Coverage Status
Change from base Build 6776286498: 0.1%
Covered Lines: 8266
Relevant Lines: 10381

💛 - Coveralls

jonathan-innis
jonathan-innis previously approved these changes Nov 6, 2023
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran enabled auto-merge (squash) November 6, 2023 19:15
@njtran njtran merged commit c3db2ec into kubernetes-sigs:main Nov 6, 2023
6 checks passed
@njtran njtran deleted the removeOldTaint branch December 26, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants