Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove provisioner utils #787

Merged
merged 3 commits into from
Nov 15, 2023
Merged

chore: remove provisioner utils #787

merged 3 commits into from
Nov 15, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Nov 15, 2023 •
edited

Fixes #N/A

Description
Removes provisioner conversion utils

How was this change tested?
make presubmit
update core on aws/karpenter and make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner November 15, 2023 16:05
@njtran njtran requested a review from jmdeal November 15, 2023 16:05
@njtran njtran enabled auto-merge (squash) November 15, 2023 16:09
@coveralls
Copy link

coveralls commented Nov 15, 2023 •
edited

Pull Request Test Coverage Report for Build 6879998797

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.08%) to 80.042%
Files with Coverage Reduction New Missed Lines %
pkg/utils/nodepool/nodepool.go 2 85.06%
pkg/utils/provisioner/provisioner.go 2 93.85%
pkg/apis/v1beta1/zz_generated.deepcopy.go 4 58.48%
Totals Coverage Status
Change from base Build 6872553443: 0.08%
Covered Lines: 8354
Relevant Lines: 10437
💛 - Coveralls

jonathan-innis
jonathan-innis approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran merged commit 8194690 into kubernetes-sigs:main Nov 15, 2023
6 checks passed
@njtran njtran deleted the removeProvisionerUtils branch November 15, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jmdeal jmdeal Awaiting requested review from jmdeal jmdeal was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@njtran @coveralls @jonathan-innis