Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Drop nodeclaim.Key from provisioner, disruption, and state #788

Merged
merged 2 commits into from
Nov 15, 2023
Merged

chore: Drop nodeclaim.Key from provisioner, disruption, and state #788

merged 2 commits into from
Nov 15, 2023

Conversation

jonathan-innis
Copy link
Member

Fixes #N/A

Description

This PR drops the nodeclaim.Key concept from provisioner, disruption, and state in favor of the NodeClaim name

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner November 15, 2023 16:22
@jonathan-innis jonathan-innis enabled auto-merge (squash) November 15, 2023 16:22
@jonathan-innis jonathan-innis force-pushed the drop-nodeclaim-key branch 11 times, most recently from e5b4cde to 3aad0bb Compare November 15, 2023 16:39
@jonathan-innis jonathan-innis force-pushed the drop-nodeclaim-key branch 2 times, most recently from d9f0023 to b6fd001 Compare November 15, 2023 16:50
@coveralls
Copy link

coveralls commented Nov 15, 2023 •
edited

Pull Request Test Coverage Report for Build 6880382139

  • 54 of 58 (93.1%) changed or added relevant lines in 7 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 79.981%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/disruption/controller.go 7 8 87.5%
pkg/controllers/state/cluster.go 17 18 94.44%
pkg/controllers/provisioning/provisioner.go 10 12 83.33%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/state/cluster.go 1 90.09%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
Totals Coverage Status
Change from base Build 6880203556: -0.08%
Covered Lines: 8342
Relevant Lines: 10430
💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 73035bb into kubernetes-sigs:main Nov 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonathan-innis @coveralls @njtran