Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update kubebuilder toolchain and test k8sversion #793

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Nov 16, 2023

Fixes #N/A

Description
This updates testing versions to K8s v1.28, and removes a stale check for kubebuilder installs when arm64 wasn't supported.

How was this change tested?
make toolchain && make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner November 16, 2023 18:53
@njtran njtran enabled auto-merge (squash) November 16, 2023 18:56
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6895197200

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 80.029%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/drift.go 2 79.1%
Totals Coverage Status
Change from base Build 6880524052: 0.02%
Covered Lines: 8347
Relevant Lines: 10430

💛 - Coveralls

@njtran njtran merged commit 91f7d0b into kubernetes-sigs:main Nov 16, 2023
6 checks passed
@njtran njtran deleted the updateK8sEnv branch December 26, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants