Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert staging changes for budgets #799

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Nov 16, 2023

Fixes #N/A

Description
Revert staging changes for budgets until it's ready to be released

The changes that are being reverted are these two, which are only API and validations/defaults.

How was this change tested?
make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner November 16, 2023 23:26
@njtran njtran requested a review from tzneal November 16, 2023 23:26
@coveralls
Copy link

coveralls commented Nov 16, 2023

Pull Request Test Coverage Report for Build 6897989090

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 34 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.03%) to 80.081%

Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 93.64%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
pkg/controllers/disruption/controller.go 25 76.06%
Totals Coverage Status
Change from base Build 6895346695: 0.03%
Covered Lines: 8338
Relevant Lines: 10412

💛 - Coveralls

@njtran njtran enabled auto-merge (squash) November 16, 2023 23:49
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran merged commit 331c506 into kubernetes-sigs:main Nov 17, 2023
6 checks passed
@njtran njtran deleted the revertBudgets1 branch December 5, 2023 01:01
njtran added a commit to njtran/karpenter that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants