Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Pin Github Action versions to hashes #801

Merged

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Nov 17, 2023

Fixes #N/A

Description

This PR pins all of our third-party actions to a full-length SHA to ensure they are not vulnerable to a supply-chain attack. This is the best practice for third-party GHA as described here: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis changed the title chore: Pin Github Action versions to hashes ci: Pin Github Action versions to hashes Nov 17, 2023
@coveralls
Copy link

coveralls commented Nov 17, 2023

Pull Request Test Coverage Report for Build 6907206257

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 80.129%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/drift.go 2 79.1%
pkg/controllers/disruption/expiration.go 2 84.38%
Totals Coverage Status
Change from base Build 6907189146: -0.04%
Covered Lines: 8343
Relevant Lines: 10412

💛 - Coveralls

@jonathan-innis jonathan-innis marked this pull request as ready for review November 17, 2023 17:31
@jonathan-innis jonathan-innis requested a review from a team as a code owner November 17, 2023 17:31
@jonathan-innis jonathan-innis enabled auto-merge (squash) November 17, 2023 17:33
Copy link
Member

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit e4c0184 into kubernetes-sigs:main Nov 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants