Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match LabelDomainExceptions correctly as label domains #808

Merged

Conversation

splichy
Copy link
Contributor

@splichy splichy commented Nov 20, 2023

Fixes #N/A

Description
Match node-restriction.kubernetes.io as the label domain instead of the exact match.

& make the GetLabelDomain function public to be re-used in Karpenter launchtemplate.go which should remove [*].node-restriction.kubernetes.io from user-data.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

coveralls commented Nov 20, 2023

Pull Request Test Coverage Report for Build 6942718573

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 80.152%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/expiration.go 2 84.38%
Totals Coverage Status
Change from base Build 6908300047: 0.05%
Covered Lines: 8347
Relevant Lines: 10414

💛 - Coveralls

@splichy splichy changed the title fix: match node-restriction.kubernetes.io correctly as label domain fix: match LabelDomainExceptions correctly as label domains Nov 20, 2023
@jonathan-innis
Copy link
Member

Looks like CI is failing. I think you need to run make presubmit again to get all of the CRD generation stuff to re-propagate.

@splichy
Copy link
Contributor Author

splichy commented Nov 21, 2023

Looks like CI is failing. I think you need to run make presubmit again to get all of the CRD generation stuff to re-propagate.

I missed hack/validation update in last commit

jonathan-innis
jonathan-innis previously approved these changes Nov 21, 2023
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit c23727b into kubernetes-sigs:main Nov 21, 2023
6 checks passed
jonathan-innis pushed a commit to jonathan-innis/karpenter that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants