Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide KERNEL_FULL_VERSION as a default build argument #400

Closed
qbarrand opened this issue May 8, 2023 · 0 comments · Fixed by #409
Closed

Provide KERNEL_FULL_VERSION as a default build argument #400

qbarrand opened this issue May 8, 2023 · 0 comments · Fixed by #409
Assignees
@qbarrand

Comments

@qbarrand
Copy link
Contributor

qbarrand commented May 8, 2023

When creating builds, we provide the KERNEL_VERSION build argument, but not KERNEL_FULL_VERSION which is substituted in the containerImage field. This creates a lot of confusion.
We should provide KERNEL_FULL_VERSION as a default build argument. The value should be identical to that of KERNEL_VERSION.
@qbarrand qbarrand self-assigned this May 8, 2023
@hershpa hershpa mentioned this issue May 8, 2023
Closed
hershpa added a commit to hershpa/kernel-module-management that referenced this issue May 9, 2023
@hershpa
Add KERNEL_FULL_VERSION as a default build argument
a13e452 
Fixes (kubernetes-sigs#400)
Signed-off-by: Hersh Pathak <hersh.pathak@intel.com>
@hershpa hershpa mentioned this issue May 9, 2023
Closed
@qbarrand qbarrand linked a pull request May 9, 2023 that will close this issue
Add KERNEL_FULL_VERSION as a default build argument #402
Closed
hershpa added a commit to hershpa/kernel-module-management that referenced this issue May 9, 2023
@hershpa
Add KERNEL_FULL_VERSION as a default build argument
8845eab 
Fixes (kubernetes-sigs#400)
Signed-off-by: Hersh Pathak <hersh.pathak@intel.com>
hershpa added a commit to hershpa/kernel-module-management that referenced this issue May 10, 2023
@hershpa
Add KERNEL_FULL_VERSION as a default build argument
3c0b243 
Fixes (kubernetes-sigs#400)
Signed-off-by: Hersh Pathak <hersh.pathak@intel.com>
hershpa added a commit to hershpa/kernel-module-management that referenced this issue May 10, 2023
@hershpa
Add KERNEL_FULL_VERSION as a default build argument
6d6d461 
Fixes kubernetes-sigs#400
Signed-off-by: Hersh Pathak <hersh.pathak@intel.com>
@hershpa hershpa mentioned this issue May 10, 2023
Merged
k8s-ci-robot pushed a commit that referenced this issue May 11, 2023
@hershpa
Add KERNEL_FULL_VERSION as a default build argument (#409)
f29ca66 
Fixes #400
Signed-off-by: Hersh Pathak <hersh.pathak@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qbarrand qbarrand

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@qbarrand