Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client-go to v12.0.0 #732

Closed
shaneutt opened this issue Jul 23, 2019 · 5 comments
Closed

Update client-go to v12.0.0 #732

shaneutt opened this issue Jul 23, 2019 · 5 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@shaneutt
Copy link
Member

What should be cleaned up or changed:

Currently if you want to include kind as a library in another tool it will hold your client-go version at v11.0.0 by default. The latest release for client-go is now v12.0.0 and it would be helpful to update kind to this version.

Why is this needed:

This makes it a bit easier to integrate with kind as a library.

@shaneutt shaneutt added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 23, 2019
@BenTheElder
Copy link
Member

Relatedly please know that the library form is significantly less stable, @munnerz and I have been working on a plan to clear that up, expect future versions of the library to change quite a bit.

We export much more than we should.

@shaneutt
Copy link
Member Author

Thanks for the heads up @BenTheElder, currently I only have a lightweight integration. I will be cautious about going deeper with that integration. 👍

@BenTheElder
Copy link
Member

We're still working on the library interface but it's actively coming along 😅

I beleive #744 removed client-go from being tracked here.

@shaneutt
Copy link
Member Author

When trying current master it seems that #744 didn't stop client-go from getting pulled in at v11.0.0+incompatible when kind is used as a library.

In case others run into this I've just been using a simple workaround in my go.mod with the replace verb e.g.:

replace k8s.io/client-go v11.0.0+incompatible => k8s.io/client-go v0.0.0-20190819141724-e14f31a72a77

@BenTheElder
Copy link
Member

thanks!

I admit i've not imported a recent version of kind into another project yet, I'm currently working on refining the library surface and usability more.

I think the replace is probably the right solution long term, it looks like we'll want to actually start using client go for #850 in the future possibly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants