Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubectl-cnpg #2241

Merged
merged 1 commit into from
May 11, 2022
Merged

Add kubectl-cnpg #2241

merged 1 commit into from
May 11, 2022

Conversation

sxd
Copy link
Contributor

@sxd sxd commented May 8, 2022

New plugin to manage CloudNativePG clusters inside Kubernetes

Signed-off-by: Jonathan Gonzalez V jonathan.gonzalez@enterprisedb.com

@ahmetb
Copy link
Member

ahmetb commented May 8, 2022

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 8, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sxd / name: Jonathan Gonzalez V. (08e6a9b)

@k8s-ci-robot k8s-ci-robot added kind/new-plugin cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 8, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @sxd!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 8, 2022
New plugin to manage CloudNativePG clusters inside Kubernetes

Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
@ahmetb
Copy link
Member

ahmetb commented May 11, 2022

/lgtm
/approve
Thanks!
Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, sxd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit c316e72 into kubernetes-sigs:master May 11, 2022
@sxd sxd deleted the new-cnpg-plugin branch May 27, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants