-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubectl plugin kc #2545
Add kubectl plugin kc #2545
Conversation
🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖 Thanks for submitting your kubectl plugin to Krew! In the meanwhile, here are a few tips to make your plugin manifest better:
Thanks for your patience! |
Welcome @astraw99! |
9b901c8
to
c7b9561
Compare
@astraw99 Are you the maintainer of the software? Or does the maintainer of the software want to package this as a kubectl plugin? We want maintainers to be intentional about this, so that they factor in this use case during the development. The repository doesn't mention usage as a plugin right now. We have some user experience expectations like you print the correct --help/usage message (e.g. On another note, we already have most all functionality listed in the --help message available across several different plugins already, but since |
Hi, I am the owner of the kubecm project and the author of kubectl-pod-lens. I'm glad @astraw99 helped to contribute this PR. Here is some feedback. I'm happy to package |
Only cosmetic comments. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, astraw99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: astraw99 <wangchengiscool@gmail.com>
c7b9561
to
8a31465
Compare
/lgtm Please consider fixing README/-help messages to indicate it can also run as a plugin. Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved. |
This plugin provide easier management of kubeconfig.
We can
list
,switch
,add
anddelete
kubeconfig ctx more efficiently.e.g.
kc add
: