Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubectl plugin kc #2545

Merged
merged 1 commit into from
Aug 28, 2022
Merged

Conversation

astraw99
Copy link
Contributor

This plugin provide easier management of kubeconfig.
We can list, switch, add and delete kubeconfig ctx more efficiently.

Available Commands:
  add         Add KubeConfig to $HOME/.kube/config
  alias       Generate alias for all contexts
  clear       Clear lapsed context, cluster and user
  cloud       Manage kubeconfig from cloud
  completion  Generate completion script
  create      Create new KubeConfig(experiment)
  delete      Delete the specified context from the kubeconfig
  help        Help about any command
  list        List KubeConfig
  merge       Merge multiple kubeconfig files into one
  namespace   Switch or change namespace interactively
  rename      Rename the contexts of kubeconfig
  switch      Switch Kube Context interactively
  version     Print version info

e.g. kc add:

kc add -f ./test_config 
 
Use the arrow keys to navigate: ↓ ↑ → ← 
Does it overwrite File 「/home/dev/.kube/config」?
    False
  🍺 True

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 25, 2022
@ahmetb
Copy link
Member

ahmetb commented Aug 25, 2022

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@k8s-ci-robot
Copy link
Contributor

Welcome @astraw99!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 25, 2022
@ahmetb
Copy link
Member

ahmetb commented Aug 25, 2022

@astraw99 Are you the maintainer of the software? Or does the maintainer of the software want to package this as a kubectl plugin? We want maintainers to be intentional about this, so that they factor in this use case during the development.

The repository doesn't mention usage as a plugin right now. We have some user experience expectations like you print the correct --help/usage message (e.g. kubectl cm instead of kubecm). Do you think the maintainer is open for
documenting installation/usage as a kubectl plugin as well?

On another note, we already have most all functionality listed in the --help message available across several different plugins already, but since kubecm seems to be an established tool, it would be okay to bring it on.

@sunny0826
Copy link
Contributor

@astraw99 Are you the maintainer of the software? Or does the maintainer of the software want to package this as a kubectl plugin? We want maintainers to be intentional about this, so that they factor in this use case during the development.

The repository doesn't mention usage as a plugin right now. We have some user experience expectations like you print the correct --help/usage message (e.g. kubectl cm instead of kubecm). Do you think the maintainer is open for documenting installation/usage as a kubectl plugin as well?

On another note, we already have most all functionality listed in the --help message available across several different plugins already, but since kubecm seems to be an established tool, it would be okay to bring it on.

Hi, I am the owner of the kubecm project and the author of kubectl-pod-lens. I'm glad @astraw99 helped to contribute this PR.

Here is some feedback.

I'm happy to package kubecm as a kubectl plugin and am willing to modify it accordingly, including help and adding the action rajatjindal/krew-release-bot etc.

plugins/kc.yaml Outdated Show resolved Hide resolved
plugins/kc.yaml Outdated Show resolved Hide resolved
@ahmetb
Copy link
Member

ahmetb commented Aug 28, 2022

Only cosmetic comments.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, astraw99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2022
Signed-off-by: astraw99 <wangchengiscool@gmail.com>
@ahmetb
Copy link
Member

ahmetb commented Aug 28, 2022

/lgtm

Please consider fixing README/-help messages to indicate it can also run as a plugin.

Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit 16595f0 into kubernetes-sigs:master Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants