New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new plugin "eks-node" #2899
Conversation
🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖 Thanks for submitting your kubectl plugin to Krew! In the meanwhile, here are a few tips to make your plugin manifest better:
Thanks for your patience! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flavono123 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @flavono123! |
The plugin print and filter AWS EKS nodes easily rather than selecting verbose named labels. This is the first version and would be improved like following: - Options for print formats(table, yaml, json) - Re-implement with Go; remove the yq dependency Signed-off-by: flavono123 <flavono123@gmail.com>
Hey, thanks for the submission. Based on what I'm seeing, this plugin won't be a good addition to krew-index because we typically reject plugins that are meant to replace things like one liners e.g. Similarly, you can expect a similar plugin would be developed for other cloud providers seeing this example, and that would further make the curated index more complex and crowded with minimal/no value add to the user (whereas "kubectl get nodes" can handle it all). (You can imagine the command inferring which labels to use from the cluster's cloud provider.) I think if it was a more generic plugin that handled multiple cloud providers (and did things which would otherwise be complicated kubectl queries with multiple pipes etc), it would be a more appealing submission. (And we typically merge plugins based on their current status; not their planned additions.) Until then you can still distribute your plugin via Krew using custom indexes: https://krew.sigs.k8s.io/docs/developer-guide/custom-indexes/ That way users can still install your plugin via Krew, but they'll be downloading the plugin manifest from your repository instead of krew-index. I hope you can develop this more and resubmit. /close |
@ahmetb: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your comment. It would be ok to use a custom index for now. |
The plugin print and filter AWS EKS nodes easily rather than selecting verbose named labels.
This is the first version and would be improved like following:
Signed-off-by: flavono123 flavono123@gmail.com