Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new plugin "eks-node" #2899

Closed
wants to merge 1 commit into from

Conversation

flavono123
Copy link

The plugin print and filter AWS EKS nodes easily rather than selecting verbose named labels.

This is the first version and would be improved like following:

  • Options for print formats(table, yaml, json)
  • Re-implement with Go; remove the yq dependency

Signed-off-by: flavono123 flavono123@gmail.com

@ahmetb
Copy link
Member

ahmetb commented Jan 29, 2023

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 29, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: flavono123 / name: Hansuk Hong (7798b4c)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flavono123
Once this PR has been reviewed and has the lgtm label, please assign corneliusweig for approval by writing /assign @corneliusweig in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/new-plugin cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 29, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @flavono123!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 29, 2023
The plugin print and filter AWS EKS nodes easily rather than
selecting verbose named labels.

This is the first version and would be improved like following:
- Options for print formats(table, yaml, json)
- Re-implement with Go; remove the yq dependency

Signed-off-by: flavono123 <flavono123@gmail.com>
@ahmetb
Copy link
Member

ahmetb commented Jan 30, 2023

Hey, thanks for the submission. Based on what I'm seeing, this plugin won't be a good addition to krew-index because we typically reject plugins that are meant to replace things like one liners e.g. kubectl get nodes -l machine-type=x.

Similarly, you can expect a similar plugin would be developed for other cloud providers seeing this example, and that would further make the curated index more complex and crowded with minimal/no value add to the user (whereas "kubectl get nodes" can handle it all). (You can imagine the command inferring which labels to use from the cluster's cloud provider.)

I think if it was a more generic plugin that handled multiple cloud providers (and did things which would otherwise be complicated kubectl queries with multiple pipes etc), it would be a more appealing submission. (And we typically merge plugins based on their current status; not their planned additions.)

Until then you can still distribute your plugin via Krew using custom indexes: https://krew.sigs.k8s.io/docs/developer-guide/custom-indexes/ That way users can still install your plugin via Krew, but they'll be downloading the plugin manifest from your repository instead of krew-index.

I hope you can develop this more and resubmit.

/close

@k8s-ci-robot
Copy link
Contributor

@ahmetb: Closed this PR.

In response to this:

Hey, thanks for the submission. Based on what I'm seeing, this plugin won't be a good addition to krew-index because we typically reject plugins that are meant to replace things like one liners e.g. kubectl get nodes -l machine-type=x.

Similarly, you can expect a similar plugin would be developed for other cloud providers seeing this example, and that would further make the curated index more complex and crowded with minimal/no value add to the user (whereas "kubectl get nodes" can handle it all). (You can imagine the command inferring which labels to use from the cluster's cloud provider.)

I think if it was a more generic plugin that handled multiple cloud providers (and did things which would otherwise be complicated kubectl queries with multiple pipes etc), it would be a more appealing submission. (And we typically merge plugins based on their current status; not their planned additions.)

Until then you can still distribute your plugin via Krew using custom indexes: https://krew.sigs.k8s.io/docs/developer-guide/custom-indexes/ That way users can still install your plugin via Krew, but they'll be downloading the plugin manifest from your repository instead of krew-index.

I hope you can develop this more and resubmit.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavono123
Copy link
Author

Thanks for your comment. It would be ok to use a custom index for now.

@flavono123 flavono123 deleted the eks-node branch January 31, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gray-area kind/new-plugin size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants