Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kubectl-validate): add validate plugin #3730

Merged
merged 7 commits into from
Jun 27, 2024
Merged

feat(kubectl-validate): add validate plugin #3730

merged 7 commits into from
Jun 27, 2024

Conversation

nlamirault
Copy link
Contributor

@nlamirault
feat(kubectl-validate): add validate plugin
1db9474 
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@ahmetb
Copy link
Member

ahmetb commented Apr 2, 2024

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖

Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 2, 2024
ahmetb
ahmetb reviewed Apr 24, 2024
View reviewed changes
plugins/validate.yaml Outdated
name: validate
spec:
version: v0.0.3
homepage: https://github.com/microsoft/retina
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems incorrect

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage: https://github.com/microsoft/retina
homepage: https://github.com/kubernetes-sigs/kubectl-validate

plugins/validate.yaml Outdated
spec:
version: v0.0.3
homepage: https://github.com/microsoft/retina
shortDescription: a SIG-CLI subproject to support the local validation of resources for native Kubernetes types and CRDs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep it <50 chars (i.e. cut to the chase)

plugins/validate.yaml Outdated
Comment on lines 10 to 14
kubectl-validate distinguishes itself among other OpenAPI-based validators by to its deep integration
with Kubernetes upstream validation. kubectl-validate is written by Kubernetes apiserver authors
using the same code as the server-side.
This allows kubectl-validate to give the most accurate error messages and support the Kubernetes-specific
validations often ignored by other tools.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap at 80 chars wide please

plugins/validate.yaml Outdated
Comment on lines 58 to 60



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please configure your editor to trim empty newlines. there should be only one \n at the end

MPV
MPV reviewed May 10, 2024
View reviewed changes
plugins/validate.yaml Outdated
Comment on lines 58 to 60



Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@ahmetb
Copy link
Member

ahmetb commented May 28, 2024

@nlamirault gentle ping. it seems like the build is failing due to a checksum error.

@nlamirault
fix: github repository
8940b50 
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault
fix: typo
9519c77 
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault
fix: trim
298bc61 
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault
fix: url of binaries
0099ade 
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault
fix: v0.0.3 url link
d03e76e 
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault
fix: name of the Windows executable
7197ae4 
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@MPV
Copy link

MPV commented Jun 3, 2024

Seems like it's green now. 🎉

@ahmetb
Copy link
Member

ahmetb commented Jun 27, 2024

/lgtm
/approve
Thanks!
Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, nlamirault

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2d81d4d into kubernetes-sigs:master Jun 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MPV MPV MPV left review comments

@ahmetb ahmetb ahmetb left review comments

@chriskim06 chriskim06 Awaiting requested review from chriskim06

Assignees

@ahmetb ahmetb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nlamirault @ahmetb @MPV @k8s-ci-robot