Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duplik8s plugin #3857

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Telemaco019
Copy link

The PR adds duplik8s to the krew index.

✅ Make sure you read the Plugin Naming Guide: https://krew.sigs.k8s.io/docs/developer-guide/develop/naming-guide/
✅ Verify you can install your plugin locally: kubectl krew install --manifest=[...] --archive=[...]

@ahmetb
Copy link
Member

ahmetb commented May 25, 2024

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Telemaco019
Once this PR has been reviewed and has the lgtm label, please assign chriskim06 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

linux-foundation-easycla bot commented May 25, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @Telemaco019!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2024
@Telemaco019 Telemaco019 changed the title feat: add duplik8s.yaml to plugins Add duplik8s plugin May 25, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 25, 2024
Copy link
Author

@Telemaco019 Telemaco019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: indentation

Edit: just ignore this comment, I was trying to make a commit directly from Github codespaces and I screwed up

fix: indentation

fix: rename

fix: typo
@ahmetb
Copy link
Member

ahmetb commented May 28, 2024

Hi, thanks for your submission. Is this plugin basically a subset of the dup plugin? https://github.com/kubernetes-sigs/krew-index/blob/master/plugins/dup.yaml

@Telemaco019
Copy link
Author

Hey @ahmetb, thanks for the heads-up about the dup plugin!

I've given it a shot by swapping out duplik8s in my setup, but it didn’t quite hit the mark for me. The cool thing about duplik8s is that it automatically tweaks parts of the Pods spec to make them debug-ready, so I don’t have to manually mess with the settings. It’s super handy because I can plug it straight into k9s and start debugging pods with just one shortcut.

To me it seems like the two plugins tackle slightly different issues:

  • dup: Focuses on debugging Kubernetes resources by allowing you to clone them with custom overridden specs.
  • duplik8s: Aims at debugging containers by cloning Pods and tweaking their specs so you can easily pop open a shell in the containers.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants