Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cert-manager: Switch to the new cmctl repository #3888

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

inteon
Copy link
Member

@inteon inteon commented Jun 10, 2024

The cert-manager command line tool has been moved to its own separate repository (https://github.com/cert-manager/cmctl).
This PR updates the krew index to point to this new repository.

@ahmetb
Copy link
Member

ahmetb commented Jun 10, 2024

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/cert-manager.yaml is not a straightforward version bump: version should have metadata ("alpha.0"), only no pre-release versions are auto-approved
/kind plugin-update

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: inteon
Once this PR has been reviewed and has the lgtm label, please assign chriskim06 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/plugin-update Version or manifest updates for existing plugins size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2024
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@ahmetb
Copy link
Member

ahmetb commented Jun 10, 2024

We don't do prerelease versions.

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
Copy link
Member Author

inteon commented Jun 11, 2024

We don't do prerelease versions.

I updated the PR to point to the v2.1.0 release now that it has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants