Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to KUDO 0.9.0 #389

Closed
wants to merge 1 commit into from
Closed

Update to KUDO 0.9.0 #389

wants to merge 1 commit into from

Conversation

alenkacz
Copy link
Contributor

No description provided.

@ahmetb
Copy link
Member

ahmetb commented Dec 17, 2019

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖

This pull request doesn't seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/kudo.yaml is not a straightforward version bump: diff line unrecognized for version bumps: [+ - selector:]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 17, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 17, 2019
@ahmetb
Copy link
Member

ahmetb commented Dec 17, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, alenkacz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2019
@jbarrick-mesosphere jbarrick-mesosphere mentioned this pull request Dec 17, 2019
Merged
@ahmetb
Copy link
Member

ahmetb commented Dec 17, 2019

Looks like Kudo will not be built for windows for some time. In that case, maybe undo the windows changes of the manifest to move forward with the new version.

@alenkacz alenkacz closed this Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetb ahmetb Awaiting requested review from ahmetb

@corneliusweig corneliusweig Awaiting requested review from corneliusweig

Assignees

@ahmetb ahmetb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alenkacz @ahmetb @k8s-ci-robot