-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubectl-kl plugin file. #3908
base: master
Are you sure you want to change the base?
Conversation
🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖 Thanks for submitting your kubectl plugin to Krew! In the meanwhile, here are a few tips to make your plugin manifest better:
Thanks for your patience! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AmitGujar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @AmitGujar! |
I'm sorry neither the plugin name is descriptive enough to reflect the plugin's functionality, nor the description clearly explains what the plugin does, and the repo has little to detail about what this plugin is about and what it looks like. I'm afraid we can't accept it in its current shape. |
Updated the description and provided descriptive name to the plugin.
Updated the following things:
|
to: . | ||
shortDescription: Switch AKS cluster on & off | ||
description: | | ||
kswitch lets you to turn AKS cluster on & off, Switch between multiple namespaces with use command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this ctx/ns plugins already do?
shortDescription: Switch AKS cluster on & off | ||
description: | | ||
kswitch lets you to turn AKS cluster on & off, Switch between multiple namespaces with use command. | ||
Additonally, it also provides the ability to create and delete namespaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this already what "kubectl delete|create namespace" already do? Why would people need an AKS specific plugin?
I followed the naming guide and I was able to install the plugin locally.
Please include my plugin.