Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version v1.3.1 of Kyverno #990

Merged
merged 1 commit into from Jan 22, 2021

Conversation

realshuting
Copy link
Contributor

No description provided.

@ahmetb
Copy link
Member

ahmetb commented Jan 21, 2021

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/kyverno.yaml is not a straightforward version bump: could not find the old/new version spec in the diff

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: realshuting
To complete the pull request process, please assign ahmetb after the PR has been reviewed.
You can assign the PR to them by writing /assign @ahmetb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 21, 2021
@realshuting
Copy link
Contributor Author

@ahmetb One more to add:

➜  krew-index git:(update_kyverno_v1.3.1) validate-krew-manifest -manifest ./plugins/kyverno.yaml
I0120 16:51:09.509899   72872 main.go:67] reading file "./plugins/kyverno.yaml"
I0120 16:51:09.511909   72872 main.go:84] structural validation OK
I0120 16:51:09.512136   72872 main.go:92] all spec.platform[] items are used
I0120 16:51:09.512332   72872 main.go:98] no overlapping spec.platform[].selector
I0120 16:51:09.512355   72872 main.go:102] installing spec.platform[0]
I0120 16:51:13.861103   72872 main.go:106] installed  spec.platforms[0]
I0120 16:51:13.861146   72872 main.go:102] installing spec.platform[1]
I0120 16:51:20.225372   72872 main.go:106] installed  spec.platforms[1]
I0120 16:51:20.225407   72872 main.go:102] installing spec.platform[2]
I0120 16:51:26.341738   72872 main.go:106] installed  spec.platforms[2]
2021/01/20 16:51:26 all 3 spec.platforms installed fine

@realshuting
Copy link
Contributor Author

Kindly ping @ahmetb, is this good to merge?

@ahmetb
Copy link
Member

ahmetb commented Jan 22, 2021

Apologies, I thought I merged this.

@ahmetb ahmetb merged commit 7040be9 into kubernetes-sigs:master Jan 22, 2021
@realshuting
Copy link
Contributor Author

Thanks @ahmetb !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants